Check for possible to wield completed craft #36230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ifreund
reviewed
Dec 18, 2019
ifreund
added
<Bugfix>
|
So I can look up details later but I believe you want to be using the can_wield function rather than just checking for two handed flag as there are other cases where you can't wield something. |
yeah can_wield() just encapsulates the same checks, ill use that, its neater. |
ghost
deleted the
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Check for possible to wield completed craft"Purpose of change
Fixes #29928
Describe the solution
The completed craft did not check if it was possible to wield the resulting item, it attempted to do so, failed then didnt actually put the item anywhere.
Ive added a check, and if wielding fails due to wearing an item that restricts hands , or not having eonugh hands ( if the item requires two hands ) , and then drops it on the floor instead of just disappearing it.
Describe alternatives you've considered
N/A
Testing
linked issue was not really about moving away from the vehicle, but the presence of vehicle cargo spots may have hidden the issue.
tested this was the cause by removing swag bag, item completed fine.
after the fix, while wearing swag bag, crafting a forge ( which requires two hands ) was them dumped on the floor.
Additional context
N/A